github-actions[bot] commented on code in PR #24818:
URL: https://github.com/apache/doris/pull/24818#discussion_r1334944382
##########
be/src/pipeline/pipeline.h:
##########
@@ -112,11 +112,11 @@ class Pipeline : public
std::enable_shared_from_this<Pipeline> {
RuntimeProfile* pipeline_profile() { return _pipeline_profile.get(); }
- const RowDescriptor& output_row_desc() const {
- return operatorXs[operatorXs.size() - 1]->row_desc();
+ [[nodiscard]] const RowDescriptor& output_row_desc() const {
+ return operatorXs.back()->row_desc();
}
- PipelineId id() const { return _pipeline_id; }
+ [[nodiscard]] PipelineId id() const { return _pipeline_id; }
Review Comment:
warning: function 'id' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] PipelineId id() const { return _pipeline_id; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
