github-actions[bot] commented on code in PR #24818:
URL: https://github.com/apache/doris/pull/24818#discussion_r1334944889
##########
be/src/pipeline/exec/table_function_operator.h:
##########
@@ -45,4 +46,115 @@ class TableFunctionOperator final : public
StatefulOperator<TableFunctionOperato
Status close(RuntimeState* state) override;
};
+
+class TableFunctionOperatorX;
+class TableFunctionLocalState final : public PipelineXLocalState<> {
+public:
+ using Parent = TableFunctionOperatorX;
+ ENABLE_FACTORY_CREATOR(TableFunctionLocalState);
+ TableFunctionLocalState(RuntimeState* state, OperatorXBase* parent);
+ ~TableFunctionLocalState() override = default;
+
+ Status init(RuntimeState* state, LocalStateInfo& info) override;
+ Status process_next_child_row();
+ Status get_expanded_block(RuntimeState* state, vectorized::Block*
output_block,
+ SourceState& source_state);
+
+private:
+ friend class TableFunctionOperatorX;
+ friend class StatefulOperatorX<TableFunctionLocalState>;
+
+ void _copy_output_slots(std::vector<vectorized::MutableColumnPtr>&
columns);
+ bool _roll_table_functions(int last_eos_idx);
+ // return:
+ // 0: all fns are eos
+ // -1: all fns are not eos
+ // >0: some of fns are eos
+ int _find_last_fn_eos_idx() const;
Review Comment:
warning: function '_find_last_fn_eos_idx' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] int _find_last_fn_eos_idx() const;
```
##########
be/src/pipeline/pipeline.h:
##########
@@ -112,11 +112,9 @@ class Pipeline : public
std::enable_shared_from_this<Pipeline> {
RuntimeProfile* pipeline_profile() { return _pipeline_profile.get(); }
- const RowDescriptor& output_row_desc() const {
- return operatorXs[operatorXs.size() - 1]->row_desc();
- }
+ [[nodiscard]] const RowDescriptor& output_row_desc() const { return
operatorXs.back()->row_desc(); }
Review Comment:
warning: function 'output_row_desc' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] const RowDescriptor& output_row_desc() const { return
operatorXs.back()->row_desc(); }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
