yiguolei commented on code in PR #24881:
URL: https://github.com/apache/doris/pull/24881#discussion_r1337049891
##########
fe/fe-core/src/main/java/org/apache/doris/common/util/RuntimeProfile.java:
##########
@@ -165,18 +173,23 @@ public void update(final TRuntimeProfileTree
thriftProfile) {
// preorder traversal, idx should be modified in the traversal process
private void update(List<TRuntimeProfileNode> nodes, Reference<Integer>
idx) {
TRuntimeProfileNode node = nodes.get(idx.getRef());
- // Make sure to update the latest LoadChannel profile according to the
timestamp.
+ // Make sure to update the latest LoadChannel profile according to the
+ // timestamp.
if (node.timestamp != -1 && node.timestamp < timestamp) {
return;
}
+ if (node.isSetMetadata()) {
+ this.nodeid = (int) node.getMetadata();
Review Comment:
I think we should not depend on it.
Add a specific field in profile object named plan_node_id.
metadata is too normal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
