yiguolei commented on code in PR #24881:
URL: https://github.com/apache/doris/pull/24881#discussion_r1339437723
##########
be/src/util/runtime_profile.cpp:
##########
@@ -278,6 +278,9 @@ RuntimeProfile* RuntimeProfile::create_child(const
std::string& name, bool inden
std::lock_guard<std::mutex> l(_children_lock);
DCHECK(_child_map.find(name) == _child_map.end());
RuntimeProfile* child = _pool->add(new RuntimeProfile(name));
+ if (this->is_set_metadata()) {
Review Comment:
这样做可能是错的，因为如果meta data 里是node id，那么child 会有自己的node id
##########
be/src/util/runtime_profile.cpp:
##########
@@ -278,6 +278,9 @@ RuntimeProfile* RuntimeProfile::create_child(const
std::string& name, bool inden
std::lock_guard<std::mutex> l(_children_lock);
DCHECK(_child_map.find(name) == _child_map.end());
RuntimeProfile* child = _pool->add(new RuntimeProfile(name));
+ if (this->is_set_metadata()) {
Review Comment:
这样做可能是错的，因为如果meta data 里是node id，那么child 会有自己的node id
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
