github-actions[bot] commented on code in PR #26710:
URL: https://github.com/apache/doris/pull/26710#discussion_r1387964628
##########
be/src/runtime/task_group/task_group_manager.cpp:
##########
@@ -59,10 +59,38 @@ void TaskGroupManager::get_resource_groups(const
std::function<bool(const TaskGr
}
}
-Status TaskGroupManager::create_and_get_task_scheduler(uint64_t tg_id,
std::string tg_name,
- int cpu_hard_limit, int
cpu_shares,
- ExecEnv* exec_env,
- QueryContext*
query_ctx_ptr) {
+TaskGroupPtr TaskGroupManager::get_task_group_by_id(uint64_t tg_id) {
Review Comment:
warning: method 'get_task_group_by_id' can be made static
[readability-convert-member-functions-to-static]
be/src/runtime/task_group/task_group_manager.h:57:
```diff
- TaskGroupPtr get_task_group_by_id(uint64_t tg_id);
+ static TaskGroupPtr get_task_group_by_id(uint64_t tg_id);
```
##########
be/src/agent/cgroup_cpu_ctl.cpp:
##########
@@ -41,6 +41,12 @@ Status CgroupCpuCtl::init() {
return Status::OK();
}
+void CgroupCpuCtl::get_cgroup_cpu_info(uint64_t* cpu_shares, uint64_t*
cpu_hard_limit) {
Review Comment:
warning: method 'get_cgroup_cpu_info' can be made const
[readability-make-member-function-const]
```suggestion
void CgroupCpuCtl::get_cgroup_cpu_info(uint64_t* cpu_shares, uint64_t*
cpu_hard_limit) const {
```
be/src/agent/cgroup_cpu_ctl.h:50:
```diff
- void get_cgroup_cpu_info(uint64_t* cpu_shares, uint64_t*
cpu_hard_limit);
+ void get_cgroup_cpu_info(uint64_t* cpu_shares, uint64_t*
cpu_hard_limit) const;
```
##########
be/src/runtime/task_group/task_group_manager.cpp:
##########
@@ -59,10 +59,38 @@
}
}
-Status TaskGroupManager::create_and_get_task_scheduler(uint64_t tg_id,
std::string tg_name,
- int cpu_hard_limit, int
cpu_shares,
- ExecEnv* exec_env,
- QueryContext*
query_ctx_ptr) {
+TaskGroupPtr TaskGroupManager::get_task_group_by_id(uint64_t tg_id) {
+ std::shared_lock<std::shared_mutex> r_lock(_group_mutex);
+ if (_task_groups.find(tg_id) != _task_groups.end()) {
+ return _task_groups.at(tg_id);
+ }
+ return nullptr;
+}
+
+bool TaskGroupManager::set_task_sche_4_query_ctx(uint64_t tg_id, QueryContext*
query_ctx_ptr) {
+ std::lock_guard<std::mutex> lock(_task_scheduler_lock);
+ if (_tg_sche_map.find(tg_id) != _tg_sche_map.end()) {
+ query_ctx_ptr->set_task_scheduler(_tg_sche_map.at(tg_id).get());
+ } else {
+ return false;
+ }
+
+ if (_tg_scan_sche_map.find(tg_id) != _tg_scan_sche_map.end()) {
+
query_ctx_ptr->set_scan_task_scheduler(_tg_scan_sche_map.at(tg_id).get());
+ } else {
+ return false;
+ }
+ return true;
+}
+
+Status TaskGroupManager::upsert_task_scheduler(taskgroup::TaskGroupInfo*
tg_info,
Review Comment:
warning: method 'upsert_task_scheduler' can be made static
[readability-convert-member-functions-to-static]
be/src/runtime/task_group/task_group_manager.h:53:
```diff
- Status upsert_task_scheduler(taskgroup::TaskGroupInfo* tg_info,
ExecEnv* exec_env);
+ static Status upsert_task_scheduler(taskgroup::TaskGroupInfo* tg_info,
ExecEnv* exec_env);
```
##########
be/src/runtime/task_group/task_group_manager.cpp:
##########
@@ -59,10 +59,38 @@
}
}
-Status TaskGroupManager::create_and_get_task_scheduler(uint64_t tg_id,
std::string tg_name,
- int cpu_hard_limit, int
cpu_shares,
- ExecEnv* exec_env,
- QueryContext*
query_ctx_ptr) {
+TaskGroupPtr TaskGroupManager::get_task_group_by_id(uint64_t tg_id) {
+ std::shared_lock<std::shared_mutex> r_lock(_group_mutex);
+ if (_task_groups.find(tg_id) != _task_groups.end()) {
+ return _task_groups.at(tg_id);
+ }
+ return nullptr;
+}
+
+bool TaskGroupManager::set_task_sche_4_query_ctx(uint64_t tg_id, QueryContext*
query_ctx_ptr) {
Review Comment:
warning: method 'set_task_sche_4_query_ctx' can be made static
[readability-convert-member-functions-to-static]
be/src/runtime/task_group/task_group_manager.h:67:
```diff
- bool set_task_sche_4_query_ctx(uint64_t tg_id, QueryContext*
query_ctx_ptr);
+ static bool set_task_sche_4_query_ctx(uint64_t tg_id, QueryContext*
query_ctx_ptr);
```
##########
be/src/runtime/task_group/task_group.cpp:
##########
@@ -185,49 +187,69 @@ void TaskGroup::task_group_info(TaskGroupInfo* tg_info)
const {
tg_info->version = _version;
}
-Status TaskGroupInfo::parse_group_info(const TPipelineWorkloadGroup&
resource_group,
- TaskGroupInfo* task_group_info) {
- if (UNLIKELY(!check_group_info(resource_group))) {
- std::stringstream ss;
- ss << "incomplete resource group parameters: ";
- resource_group.printTo(ss);
- LOG(WARNING) << ss.str();
- return Status::InternalError(ss.str());
- }
-
- auto iter = resource_group.properties.find(CPU_SHARE);
- uint64_t share = 0;
- std::from_chars(iter->second.c_str(), iter->second.c_str() +
iter->second.size(), share);
-
+Status TaskGroupInfo::parse_topic_info(const TopicInfo& topic_info,
Review Comment:
warning: method 'parse_topic_info' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status TaskGroupInfo::parse_topic_info(const TopicInfo& topic_info,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
