yiguolei commented on code in PR #26710:
URL: https://github.com/apache/doris/pull/26710#discussion_r1388043540


##########
gensrc/thrift/BackendService.thrift:
##########
@@ -165,9 +165,8 @@ enum TTopicInfoType {
 }
 
 struct TopicInfo {
-    1: optional string topic_key
-    2: required TTopicInfoType topic_type
-    3: optional map<string, string> info_map
+    1: required TTopicInfoType topic_type

Review Comment:
   never use  required field



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to