JNSimba commented on code in PR #226:
URL: 
https://github.com/apache/doris-flink-connector/pull/226#discussion_r1391979582


##########
flink-doris-connector/src/main/java/org/apache/doris/flink/sink/writer/LabelGenerator.java:
##########
@@ -24,6 +24,8 @@
  * Generator label for stream load.
  */
 public class LabelGenerator {
+
+    private static final int MAX_LOAD_LABEL_LENGTH = 128;

Review Comment:
    can you post the reasons here? such as label restrictions, etc.



##########
flink-doris-connector/src/main/java/org/apache/doris/flink/sink/writer/LabelGenerator.java:
##########
@@ -24,6 +24,8 @@
  * Generator label for stream load.
  */
 public class LabelGenerator {
+
+    private static final int MAX_LOAD_LABEL_LENGTH = 128;

Review Comment:
    can you post the reasons here? such as label restrictions, etc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to