github-actions[bot] commented on code in PR #27108:
URL: https://github.com/apache/doris/pull/27108#discussion_r1395320661
##########
be/src/vec/exec/format/parquet/schema_desc.cpp:
##########
@@ -239,6 +240,72 @@
return type;
}
+// Copy from org.apache.iceberg.avro.AvroSchemaUtil#validAvroName
+static bool is_valid_avro_name(const std::string& name) {
+ int length = name.length();
+ char first = name[0];
+ if (!(isalpha(first) || first == '_')) {
+ return false;
+ }
+
+ for (int i = 1; i < length; i++) {
+ char character = name[i];
+ if (!(isalpha(character) || isdigit(character) || character == '_')) {
+ return false;
+ }
+ }
+ return true;
+}
+
+// Copy from org.apache.iceberg.avro.AvroSchemaUtil#sanitize
+static void sanitize_avro_name(std::ostringstream& buf, char character) {
+ if (isdigit(character)) {
+ buf << '_' << character;
+ } else {
+ std::stringstream ss;
+ ss << std::hex << (int)character;
+ std::string hex_str = ss.str();
+ buf << "_x" << doris::to_lower(hex_str);
+ }
+}
+
+// Copy from org.apache.iceberg.avro.AvroSchemaUtil#sanitize
+static std::string sanitize_avro_name(const std::string& name) {
+ std::ostringstream buf;
+ int length = name.length();
+ char first = name[0];
+ if (!(isalpha(first) || first == '_')) {
Review Comment:
warning: boolean expression can be simplified by DeMorgan's theorem
[readability-simplify-boolean-expr]
```suggestion
if (!isalpha(first) && first != '_') {
```
##########
be/src/vec/exec/format/parquet/schema_desc.cpp:
##########
@@ -239,6 +240,72 @@ TypeDescriptor FieldDescriptor::get_doris_type(const
tparquet::SchemaElement& ph
return type;
}
+// Copy from org.apache.iceberg.avro.AvroSchemaUtil#validAvroName
+static bool is_valid_avro_name(const std::string& name) {
+ int length = name.length();
+ char first = name[0];
+ if (!(isalpha(first) || first == '_')) {
Review Comment:
warning: boolean expression can be simplified by DeMorgan's theorem
[readability-simplify-boolean-expr]
```suggestion
if (!isalpha(first) && first != '_') {
```
##########
be/src/vec/exec/format/parquet/schema_desc.cpp:
##########
@@ -239,6 +240,72 @@
return type;
}
+// Copy from org.apache.iceberg.avro.AvroSchemaUtil#validAvroName
+static bool is_valid_avro_name(const std::string& name) {
+ int length = name.length();
+ char first = name[0];
+ if (!(isalpha(first) || first == '_')) {
+ return false;
+ }
+
+ for (int i = 1; i < length; i++) {
+ char character = name[i];
+ if (!(isalpha(character) || isdigit(character) || character == '_')) {
+ return false;
+ }
+ }
+ return true;
+}
+
+// Copy from org.apache.iceberg.avro.AvroSchemaUtil#sanitize
+static void sanitize_avro_name(std::ostringstream& buf, char character) {
+ if (isdigit(character)) {
+ buf << '_' << character;
+ } else {
+ std::stringstream ss;
+ ss << std::hex << (int)character;
+ std::string hex_str = ss.str();
+ buf << "_x" << doris::to_lower(hex_str);
+ }
+}
+
+// Copy from org.apache.iceberg.avro.AvroSchemaUtil#sanitize
+static std::string sanitize_avro_name(const std::string& name) {
+ std::ostringstream buf;
+ int length = name.length();
+ char first = name[0];
+ if (!(isalpha(first) || first == '_')) {
+ sanitize_avro_name(buf, first);
+ } else {
+ buf << first;
+ }
+
+ for (int i = 1; i < length; i++) {
+ char character = name[i];
+ if (!(isalpha(character) || isdigit(character) || character == '_')) {
Review Comment:
warning: boolean expression can be simplified by DeMorgan's theorem
[readability-simplify-boolean-expr]
```suggestion
if (!isalpha(character) && !isdigit(character) && character != '_') {
```
##########
be/src/vec/exec/format/parquet/schema_desc.cpp:
##########
@@ -239,6 +240,72 @@
return type;
}
+// Copy from org.apache.iceberg.avro.AvroSchemaUtil#validAvroName
+static bool is_valid_avro_name(const std::string& name) {
+ int length = name.length();
+ char first = name[0];
+ if (!(isalpha(first) || first == '_')) {
+ return false;
+ }
+
+ for (int i = 1; i < length; i++) {
+ char character = name[i];
+ if (!(isalpha(character) || isdigit(character) || character == '_')) {
Review Comment:
warning: boolean expression can be simplified by DeMorgan's theorem
[readability-simplify-boolean-expr]
```suggestion
if (!isalpha(character) && !isdigit(character) && character != '_') {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
