AshinGau commented on code in PR #27108:
URL: https://github.com/apache/doris/pull/27108#discussion_r1396704083
##########
be/src/vec/exec/scan/vfile_scanner.cpp:
##########
@@ -969,16 +968,11 @@ Status VFileScanner::_generate_fill_columns() {
return Status::InternalError("failed to find default value
expr for slot: {}",
slot_desc->col_name());
}
- _missing_columns->emplace(slot_desc->col_name(), it->second);
+ _missing_col_descs.emplace(slot_desc->col_name(), it->second);
}
}
- RETURN_IF_ERROR(_cur_reader->set_fill_columns(*_partition_columns,
*_missing_columns));
- if (_cur_reader->fill_all_columns()) {
Review Comment:
Because adding this will make the logic even more confusing. There's no need
for cleaning the `_partition_columns` and `_partition_columns `.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
