github-actions[bot] commented on code in PR #27587:
URL: https://github.com/apache/doris/pull/27587#discussion_r1405425420
##########
be/src/exec/schema_scanner.h:
##########
@@ -53,22 +53,22 @@ struct SchemaScannerCommonParam {
ip(nullptr),
port(0),
catalog(nullptr) {}
- const std::string* db;
- const std::string* table;
- const std::string* wild;
- const std::string* user; // deprecated
- const std::string* user_ip; // deprecated
- const TUserIdentity* current_user_ident; // to replace the user and user ip
- const std::string* ip; // frontend ip
- int32_t port; // frontend thrift port
+ const std::string* db = nullptr;
+ const std::string* table = nullptr;
+ const std::string* wild = nullptr;
+ const std::string* user = nullptr; // deprecated
+ const std::string* user_ip = nullptr; // deprecated
+ const TUserIdentity* current_user_ident = nullptr; // to replace the user
and user ip
+ const std::string* ip = nullptr; // frontend ip
+ int32_t port; // frontend thrift port
Review Comment:
warning: use default member initializer for 'port'
[modernize-use-default-member-init]
be/src/exec/schema_scanner.h:53:
```diff
- port(0),
+ ,
```
```suggestion
int32_t port{0}; // frontend thrift
port
```
##########
be/src/olap/hll.h:
##########
@@ -359,11 +359,11 @@
void parse();
private:
- char* _buf_ref; // set
- int _buf_len; // set len
- HllDataType _set_type; //set type
- char* _full_value_position;
- uint64_t* _explicit_value;
+ char* _buf_ref = nullptr; // set
+ int _buf_len; // set len
+ HllDataType _set_type; //set type
Review Comment:
warning: use default member initializer for '_set_type'
[modernize-use-default-member-init]
be/src/olap/hll.h:318:
```diff
- _set_type(HLL_DATA_EMPTY),
+ ,
```
```suggestion
HllDataType _set_type{HLL_DATA_EMPTY}; //set type
```
##########
be/src/olap/hll.h:
##########
@@ -359,11 +359,11 @@ class HllSetResolver {
void parse();
private:
- char* _buf_ref; // set
- int _buf_len; // set len
- HllDataType _set_type; //set type
- char* _full_value_position;
- uint64_t* _explicit_value;
+ char* _buf_ref = nullptr; // set
+ int _buf_len; // set len
Review Comment:
warning: use default member initializer for '_buf_len'
[modernize-use-default-member-init]
be/src/olap/hll.h:317:
```diff
- _buf_len(0),
+ ,
```
```suggestion
int _buf_len{0}; // set len
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
