github-actions[bot] commented on code in PR #27587:
URL: https://github.com/apache/doris/pull/27587#discussion_r1405426919
##########
be/src/olap/hll.h:
##########
@@ -359,11 +359,11 @@ class HllSetResolver {
void parse();
private:
- char* _buf_ref; // set
- int _buf_len; // set len
- HllDataType _set_type; //set type
- char* _full_value_position;
- uint64_t* _explicit_value;
+ char* _buf_ref = nullptr; // set
+ int _buf_len; // set len
Review Comment:
warning: use default member initializer for '_buf_len'
[modernize-use-default-member-init]
be/src/olap/hll.h:317:
```diff
- _buf_len(0),
+ ,
```
```suggestion
int _buf_len{0}; // set len
```
##########
be/src/olap/hll.h:
##########
@@ -359,11 +359,11 @@
void parse();
private:
- char* _buf_ref; // set
- int _buf_len; // set len
- HllDataType _set_type; //set type
- char* _full_value_position;
- uint64_t* _explicit_value;
+ char* _buf_ref = nullptr; // set
+ int _buf_len; // set len
+ HllDataType _set_type; //set type
Review Comment:
warning: use default member initializer for '_set_type'
[modernize-use-default-member-init]
be/src/olap/hll.h:318:
```diff
- _set_type(HLL_DATA_EMPTY),
+ ,
```
```suggestion
HllDataType _set_type{HLL_DATA_EMPTY}; //set type
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
