github-actions[bot] commented on code in PR #27852:
URL: https://github.com/apache/doris/pull/27852#discussion_r1411739608
##########
be/src/pipeline/exec/exchange_sink_operator.cpp:
##########
@@ -245,7 +245,7 @@ Status ExchangeSinkLocalState::open(RuntimeState* state) {
return Status::OK();
}
-std::string ExchangeSinkLocalState::id_name() {
+std::string ExchangeSinkLocalState::name_suffix() {
Review Comment:
warning: method 'name_suffix' can be made static
[readability-convert-member-functions-to-static]
be/src/pipeline/exec/exchange_sink_operator.h:186:
```diff
- std::string name_suffix() override;
+ static std::string name_suffix() override;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
