github-actions[bot] commented on code in PR #27852:
URL: https://github.com/apache/doris/pull/27852#discussion_r1411764557
##########
be/src/pipeline/exec/hashjoin_build_sink.h:
##########
@@ -155,6 +155,14 @@ class HashJoinBuildSinkOperatorX final
._should_build_hash_table;
}
+ std::vector<TExpr> get_local_shuffle_exprs() const override { return
_partition_exprs; }
+ ExchangeType get_local_exchange_type() const override {
Review Comment:
warning: method 'get_local_exchange_type' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static ExchangeType get_local_exchange_type() override {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
