github-actions[bot] commented on code in PR #28084:
URL: https://github.com/apache/doris/pull/28084#discussion_r1418310166
##########
be/src/runtime/load_stream_writer.cpp:
##########
@@ -120,7 +120,8 @@ Status LoadStreamWriter::close_segment(uint32_t segid) {
return Status::OK();
}
-Status LoadStreamWriter::add_segment(uint32_t segid, const SegmentStatistics&
stat) {
+Status LoadStreamWriter::add_segment(uint32_t segid, const SegmentStatistics&
stat,
Review Comment:
warning: method 'add_segment' can be made static
[readability-convert-member-functions-to-static]
be/src/runtime/load_stream_writer.h:73:
```diff
- Status add_segment(uint32_t segid, const SegmentStatistics& stat,
TabletSchemaSPtr flush_chema);
+ static Status add_segment(uint32_t segid, const SegmentStatistics&
stat, TabletSchemaSPtr flush_chema);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
