kaijchen commented on code in PR #28084:
URL: https://github.com/apache/doris/pull/28084#discussion_r1418324789
##########
be/src/olap/rowset/segment_creator.cpp:
##########
@@ -344,7 +342,7 @@ Status SegmentFlusher::_flush_segment_writer(
writer.reset();
- RETURN_IF_ERROR(_context->segment_collector->add(segment_id, segstat));
+ RETURN_IF_ERROR(_context->segment_collector->add(segment_id, segstat,
_flush_schema));
Review Comment:
Add an argument `FlushSchemaSPtr flush_schema` to `_flush_segment_writer()`,
avoid adding `_flush_schema` to the class.
##########
be/src/olap/rowset/segment_creator.cpp:
##########
@@ -386,7 +384,7 @@ Status
SegmentFlusher::_flush_segment_writer(std::unique_ptr<segment_v2::Segment
writer.reset();
- RETURN_IF_ERROR(_context->segment_collector->add(segment_id, segstat));
+ RETURN_IF_ERROR(_context->segment_collector->add(segment_id, segstat,
_flush_schema));
Review Comment:
and here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
