morningman commented on a change in pull request #5783:
URL: https://github.com/apache/incubator-doris/pull/5783#discussion_r634008297
##########
File path: be/src/common/config.h
##########
@@ -597,6 +597,8 @@ CONF_mInt32(zone_map_row_num_threshold, "20");
// Trace = 6
CONF_Int32(aws_log_level, "3");
+// default level of MemTracker to show in webpage
Review comment:
Explain whether this value is higher and more detailed or lower and more
detailed.
##########
File path: be/src/runtime/tablets_channel.cpp
##########
@@ -34,7 +34,7 @@ std::atomic<uint64_t> TabletsChannel::_s_tablet_writer_count;
TabletsChannel::TabletsChannel(const TabletsChannelKey& key,
const std::shared_ptr<MemTracker>& mem_tracker)
: _key(key), _state(kInitialized), _closed_senders(64) {
- _mem_tracker = MemTracker::CreateTracker(-1, "TabletsChannel:" +
key.to_string(), mem_tracker);
+ _mem_tracker = MemTracker::CreateTracker(-1, "TabletsChannel",
mem_tracker);
Review comment:
Why remove key?
##########
File path: be/src/olap/memtable.cpp
##########
@@ -40,7 +40,7 @@ MemTable::MemTable(int64_t tablet_id, Schema* schema, const
TabletSchema* tablet
_slot_descs(slot_descs),
_keys_type(keys_type),
_row_comparator(_schema),
- _mem_tracker(MemTracker::CreateTracker(-1, "MemTable:" +
std::to_string(tablet_id), parent_tracker)),
+ _mem_tracker(MemTracker::CreateTracker(-1, "MemTable",
parent_tracker)),
Review comment:
Why remove tablet id?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
