HappenLee commented on a change in pull request #5783:
URL: https://github.com/apache/incubator-doris/pull/5783#discussion_r634081087
##########
File path: be/src/olap/memtable.cpp
##########
@@ -40,7 +40,7 @@ MemTable::MemTable(int64_t tablet_id, Schema* schema, const
TabletSchema* tablet
_slot_descs(slot_descs),
_keys_type(keys_type),
_row_comparator(_schema),
- _mem_tracker(MemTracker::CreateTracker(-1, "MemTable:" +
std::to_string(tablet_id), parent_tracker)),
+ _mem_tracker(MemTracker::CreateTracker(-1, "MemTable",
parent_tracker)),
Review comment:
Beacause the tracker will use the parent label id
##########
File path: be/src/runtime/tablets_channel.cpp
##########
@@ -34,7 +34,7 @@ std::atomic<uint64_t> TabletsChannel::_s_tablet_writer_count;
TabletsChannel::TabletsChannel(const TabletsChannelKey& key,
const std::shared_ptr<MemTracker>& mem_tracker)
: _key(key), _state(kInitialized), _closed_senders(64) {
- _mem_tracker = MemTracker::CreateTracker(-1, "TabletsChannel:" +
key.to_string(), mem_tracker);
+ _mem_tracker = MemTracker::CreateTracker(-1, "TabletsChannel",
mem_tracker);
Review comment:
The same to up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
