adonis0147 commented on code in PR #28429:
URL: https://github.com/apache/doris/pull/28429#discussion_r1429042727
##########
thirdparty/build-thirdparty.sh:
##########
@@ -1066,13 +1066,15 @@ build_arrow() {
"${BUILD_SYSTEM}" install
#copy dep libs
- cp -rf ./jemalloc_ep-prefix/src/jemalloc_ep/dist/lib/libjemalloc_pic.a
"${TP_INSTALL_DIR}/lib64/libjemalloc.a"
+ cp -rf ./jemalloc_ep-prefix/src/jemalloc_ep/dist/lib/libjemalloc_pic.a
"${TP_INSTALL_DIR}/lib64/libjemalloc_arrow.a"
cp -rf ./brotli_ep/src/brotli_ep-install/lib/libbrotlienc-static.a
"${TP_INSTALL_DIR}/lib64/libbrotlienc.a"
cp -rf ./brotli_ep/src/brotli_ep-install/lib/libbrotlidec-static.a
"${TP_INSTALL_DIR}/lib64/libbrotlidec.a"
cp -rf ./brotli_ep/src/brotli_ep-install/lib/libbrotlicommon-static.a
"${TP_INSTALL_DIR}/lib64/libbrotlicommon.a"
strip_lib libarrow.a
- strip_lib libjemalloc.a
+ strip_lib libjemalloc_arrow.a
strip_lib libparquet.a
+
+ cp -rf "${TP_INSTALL_DIR}/lib64/libjemalloc_arrow.a"
"${TP_INSTALL_DIR}/lib64/libjemalloc.a" # TODO delete
Review Comment:
This line will overwrite the static library (libjemalloc.a) built before in
the function `build_jemalloc`. Is it right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
