xinyiZzz commented on code in PR #28429:
URL: https://github.com/apache/doris/pull/28429#discussion_r1429206145
##########
thirdparty/build-thirdparty.sh:
##########
@@ -1066,13 +1066,15 @@ build_arrow() {
"${BUILD_SYSTEM}" install
#copy dep libs
- cp -rf ./jemalloc_ep-prefix/src/jemalloc_ep/dist/lib/libjemalloc_pic.a
"${TP_INSTALL_DIR}/lib64/libjemalloc.a"
+ cp -rf ./jemalloc_ep-prefix/src/jemalloc_ep/dist/lib/libjemalloc_pic.a
"${TP_INSTALL_DIR}/lib64/libjemalloc_arrow.a"
cp -rf ./brotli_ep/src/brotli_ep-install/lib/libbrotlienc-static.a
"${TP_INSTALL_DIR}/lib64/libbrotlienc.a"
cp -rf ./brotli_ep/src/brotli_ep-install/lib/libbrotlidec-static.a
"${TP_INSTALL_DIR}/lib64/libbrotlidec.a"
cp -rf ./brotli_ep/src/brotli_ep-install/lib/libbrotlicommon-static.a
"${TP_INSTALL_DIR}/lib64/libbrotlicommon.a"
strip_lib libarrow.a
- strip_lib libjemalloc.a
+ strip_lib libjemalloc_arrow.a
strip_lib libparquet.a
+
+ cp -rf "${TP_INSTALL_DIR}/lib64/libjemalloc_arrow.a"
"${TP_INSTALL_DIR}/lib64/libjemalloc.a" # TODO delete
Review Comment:
`build_jemalloc` set the suffix `--with-install-suffix="_doris"`, the
compiled static library is `libjemalloc_doris.a`.
Here `cp -rf libjemalloc_arrow.a libjemalloc.a` is just for compatibility,
this line will be deleted later, only `libjemalloc_arrow.a` and
`libjemalloc_doris.a` in `thirdparty/install/lib`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
