weizuo93 commented on a change in pull request #5781:
URL: https://github.com/apache/incubator-doris/pull/5781#discussion_r656775743
##########
File path: be/src/olap/olap_server.cpp
##########
@@ -334,6 +334,30 @@ void StorageEngine::_compaction_tasks_producer_callback() {
int64_t interval = config::generate_compaction_tasks_min_interval_ms;
do {
if (!config::disable_auto_compaction) {
+ VLOG_CRITICAL << "compaction thread pool. num_threads: " <<
_compaction_thread_pool->num_threads()
+ << ", num_threads_pending_start: " <<
_compaction_thread_pool->num_threads_pending_start()
+ << ", num_active_threads: " <<
_compaction_thread_pool->num_active_threads()
+ << ", max_threads: " <<
_compaction_thread_pool->max_threads()
+ << ", min_threads: " <<
_compaction_thread_pool->min_threads()
+ << ", num_total_queued_tasks: " <<
_compaction_thread_pool->num_total_queued_tasks();
+
+ if(_compaction_thread_pool->max_threads() !=
config::max_compaction_threads) {
+ Status status =
_compaction_thread_pool->set_max_threads(config::max_compaction_threads);
+ if (status.ok()) {
+ LOG(INFO) << "update compaction thread pool max_threads
from "
+ << _compaction_thread_pool->max_threads() << "
to "
+ << config::max_compaction_threads;
+ }
+ }
+ if(_compaction_thread_pool->min_threads() !=
config::max_compaction_threads) {
+ Status status =
_compaction_thread_pool->set_min_threads(config::max_compaction_threads);
+ if (status.ok()) {
Review comment:
> what if it returns failure?
There are two possibilities if it returns failure.
(1) We turn up the config `max_compaction_threads`. Similar to the above,
`_max_threads` hasn't been adjusted yet.`set_min_threads()` will be executed
again next round in compaction producer and turn up `_min_threads`.
(2) Failed to create new thread. We don't need to worry. When compaction
task is submitted to thread pool, a new thread will be created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
