weizuo93 commented on a change in pull request #5781:
URL: https://github.com/apache/incubator-doris/pull/5781#discussion_r656776040
##########
File path: be/src/util/threadpool.cpp
##########
@@ -610,6 +607,35 @@ void ThreadPool::check_not_pool_thread_unlocked() {
}
}
+Status ThreadPool::set_min_threads(int min_threads) {
+ if (min_threads <= _max_threads) {
+ int old_min_threads = _min_threads;
+ _min_threads = min_threads;
+ if (min_threads > _num_threads + _num_threads_pending_start) {
+ int addition_threads = min_threads - _num_threads -
_num_threads_pending_start;
+ _num_threads_pending_start += addition_threads;
+ for (int i = 0; i < addition_threads; i++) {
+ Status status = create_thread();
+ if (!status.ok()) {
+ _num_threads_pending_start--;
+ LOG(ERROR) << "Thread pool failed to create thread: " <<
status.to_string();
Review comment:
> use WARNING
OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
