github-actions[bot] commented on code in PR #29434:
URL: https://github.com/apache/doris/pull/29434#discussion_r1439483699
##########
be/src/olap/wal/wal_manager.cpp:
##########
@@ -232,8 +232,8 @@ void WalManager::print_wal_status_queue() {
LOG(INFO) << ss.str();
}
-Status WalManager::add_wal_path(int64_t db_id, int64_t table_id, int64_t
wal_id,
- const std::string& label, std::string&
base_path) {
+Status WalManager::create_wal_path(int64_t db_id, int64_t table_id, int64_t
wal_id,
Review Comment:
warning: method 'create_wal_path' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status WalManager::create_wal_path(int64_t db_id, int64_t table_id,
int64_t wal_id,
```
##########
be/src/olap/wal/wal_dirs_info.cpp:
##########
@@ -178,11 +175,13 @@ Status WalDirsInfo::update_all_wal_dir_used() {
return Status::OK();
}
-Status WalDirsInfo::update_wal_dir_pre_allocated(std::string wal_dir, size_t
pre_allocated,
- bool is_add_pre_allocated) {
+Status WalDirsInfo::update_wal_dir_pre_allocated(std::string wal_dir, size_t
increase_pre_allocated,
Review Comment:
warning: method 'update_wal_dir_pre_allocated' can be made static
[readability-convert-member-functions-to-static]
be/src/olap/wal/wal_dirs_info.h:71:
```diff
- Status update_wal_dir_pre_allocated(std::string wal_dir, size_t
increase_pre_allocated,
+ static Status update_wal_dir_pre_allocated(std::string wal_dir, size_t
increase_pre_allocated,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
