mymeiyi commented on code in PR #29434:
URL: https://github.com/apache/doris/pull/29434#discussion_r1440009004
##########
be/src/olap/wal/wal_dirs_info.cpp:
##########
@@ -74,7 +71,7 @@ Status WalDirInfo::update_wal_dir_limit(size_t limit) {
}
size_t wal_dir_size = 0;
RETURN_IF_ERROR(io::global_local_filesystem()->directory_size(_wal_dir,
&wal_dir_size));
- // TODO should be wal_disk_limit + wal_dir_size
+ // If here we set wal_disk_limit + wal_dir_size, then wal dir size
will be larger and larger.
Review Comment:
If not add, the above get wal_dir_size is unused?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
