github-actions[bot] commented on code in PR #29439:
URL: https://github.com/apache/doris/pull/29439#discussion_r1439710313
##########
be/src/exprs/runtime_filter_slots.h:
##########
@@ -204,10 +204,10 @@ class VRuntimeFilterSlots {
}
// publish runtime filter
- Status publish() {
+ Status publish(bool publish_local = false) {
Review Comment:
warning: method 'publish' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status publish(bool publish_local = false) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
