Gabriel39 commented on code in PR #29439:
URL: https://github.com/apache/doris/pull/29439#discussion_r1440016363
##########
be/src/exprs/runtime_filter.cpp:
##########
@@ -1010,13 +1010,17 @@ Status IRuntimeFilter::publish() {
filter->update_runtime_filter_type_to_profile();
filter->signal();
}
- return Status::OK();
- } else {
+ } else if (!publish_local) {
TNetworkAddress addr;
DCHECK(_state != nullptr);
RETURN_IF_ERROR(_state->runtime_filter_mgr->get_merge_addr(&addr));
return push_to_remote(_state, &addr, _opt_remote_rf);
+ } else {
+ // remote broadcast join only push onetime in build shared hash table
+ // publish_local only set true on copy shared hash table
+ DCHECK(_is_broadcast_join);
Review Comment:
This will cause correctness problem if multiple targets on different BE
should be broadcasted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
