github-actions[bot] commented on code in PR #29605:
URL: https://github.com/apache/doris/pull/29605#discussion_r1442687486
##########
be/src/vec/sink/writer/async_result_writer.h:
##########
@@ -98,7 +98,7 @@ class AsyncResultWriter : public ResultWriter {
void _return_free_block(std::unique_ptr<Block>);
-private:
+protected:
Review Comment:
warning: redundant access specifier has the same accessibility as the
previous access specifier [readability-redundant-access-specifiers]
```suggestion
```
<details>
<summary>Additional context</summary>
**be/src/vec/sink/writer/async_result_writer.h:92:** previously declared here
```cpp
protected:
^
```
</details>
##########
be/src/vec/sink/vresult_file_sink.cpp:
##########
@@ -110,41 +113,52 @@ Status VResultFileSink::open(RuntimeState* state) {
return AsyncWriterSink::open(state);
}
-Status VResultFileSink::close(RuntimeState* state, Status exec_status) {
- if (_closed) {
- return Status::OK();
+Status VResultFileSink::try_close(RuntimeState* state, Status /*exec_status*/)
{
Review Comment:
warning: method 'try_close' can be made const
[readability-make-member-function-const]
```suggestion
Status VResultFileSink::try_close(RuntimeState* state, Status
/*exec_status*/) const {
```
be/src/vec/sink/vresult_file_sink.h:65:
```diff
- Status try_close(RuntimeState* state, Status exec_status) override;
+ Status try_close(RuntimeState* state, Status exec_status) const
override;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
