yiguolei commented on code in PR #29605:
URL: https://github.com/apache/doris/pull/29605#discussion_r1442690303
##########
be/src/runtime/result_writer.h:
##########
@@ -38,6 +38,10 @@ class ResultWriter {
virtual Status init(RuntimeState* state) = 0;
+ // WIP: should be renamed to flush/finish or something like this
+ // arg Status is added only for compatible with current signature
+ virtual Status try_close(RuntimeState* state, Status status) { return
Status::OK(); }
Review Comment:
不要传递status了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
