HappenLee commented on code in PR #29727:
URL: https://github.com/apache/doris/pull/29727#discussion_r1446819155
##########
be/src/exprs/runtime_filter_slots.h:
##########
@@ -166,26 +166,24 @@ class VRuntimeFilterSlots {
return Status::OK();
}
- void insert(const std::unordered_set<const vectorized::Block*>& datas) {
+ void insert(const vectorized::Block* block) {
for (int i = 0; i < _build_expr_context.size(); ++i) {
auto iter = _runtime_filters.find(i);
if (iter == _runtime_filters.end()) {
continue;
}
int result_column_id =
_build_expr_context[i]->get_last_result_column_id();
- for (const auto* it : datas) {
- auto column = it->get_by_position(result_column_id).column;
- for (auto* filter : iter->second) {
- filter->insert_batch(column, 1);
- }
+ auto column = block->get_by_position(result_column_id).column;
Review Comment:
use reference ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
