HappenLee commented on code in PR #29727:
URL: https://github.com/apache/doris/pull/29727#discussion_r1446825004
##########
be/src/pipeline/exec/hashjoin_build_sink.cpp:
##########
@@ -482,29 +482,20 @@ Status HashJoinBuildSinkOperatorX::sink(RuntimeState*
state, vectorized::Block*
local_state._build_side_mutable_block.to_block());
COUNTER_UPDATE(local_state._build_blocks_memory_usage,
(*local_state._shared_state->build_block).bytes());
- RETURN_IF_ERROR(
- local_state.process_build_block(state,
(*local_state._shared_state->build_block)));
const bool use_global_rf =
local_state._parent->cast<HashJoinBuildSinkOperatorX>()._use_global_rf;
- auto ret = std::visit(
- Overload {[&](std::monostate&) -> Status {
- LOG(FATAL) << "FATAL: uninited hash table";
- __builtin_unreachable();
- },
- [&](auto&& arg) -> Status {
- vectorized::ProcessRuntimeFilterBuild
runtime_filter_build_process;
- return runtime_filter_build_process(state, arg,
&local_state,
-
use_global_rf);
- }},
- *local_state._shared_state->hash_table_variants);
+ auto ret = vectorized::process_runtime_filter_build(
+ state, local_state._shared_state->build_block.get(),
&local_state, use_global_rf);
if (!ret.ok()) {
Review Comment:
recheck the logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
