yiguolei commented on code in PR #31067:
URL: https://github.com/apache/doris/pull/31067#discussion_r1496965184
##########
be/src/vec/exec/join/vhash_join_node.cpp:
##########
@@ -180,9 +180,17 @@ Status HashJoinNode::init(const TPlanNode& tnode,
RuntimeState* state) {
#endif
for (size_t i = 0; i < _runtime_filter_descs.size(); i++) {
- RETURN_IF_ERROR(state->runtime_filter_mgr()->register_producer_filter(
- _runtime_filter_descs[i], state->query_options(),
&_runtime_filters[i],
- _probe_expr_ctxs.size() == 1));
+ if (_runtime_filter_descs[i].has_remote_targets) {
+ RETURN_IF_ERROR(state->get_query_ctx()
Review Comment:
duplicate code, add a new method in runtimestate register_producer_filter(
_runtime_filter_descs[i], state->query_options(), &_runtime_filters[i],
_probe_expr_ctxs.size() == 1))
and then check if it is a local or global runtime filter inside the method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
