github-actions[bot] commented on code in PR #31067:
URL: https://github.com/apache/doris/pull/31067#discussion_r1497137595
##########
be/src/runtime/runtime_state.cpp:
##########
@@ -506,4 +502,32 @@ bool RuntimeState::enable_page_cache() const {
(_query_options.__isset.enable_page_cache &&
_query_options.enable_page_cache);
}
+RuntimeFilterMgr* RuntimeState::global_runtime_filter_mgr() {
+ return _query_ctx->runtime_filter_mgr();
+}
+
+Status RuntimeState::register_producer_runtime_filter(const
doris::TRuntimeFilterDesc& desc,
Review Comment:
warning: method 'register_producer_runtime_filter' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status RuntimeState::register_producer_runtime_filter(const
doris::TRuntimeFilterDesc& desc,
```
##########
be/src/runtime/runtime_state.cpp:
##########
@@ -506,4 +502,32 @@
(_query_options.__isset.enable_page_cache &&
_query_options.enable_page_cache);
}
+RuntimeFilterMgr* RuntimeState::global_runtime_filter_mgr() {
+ return _query_ctx->runtime_filter_mgr();
+}
+
+Status RuntimeState::register_producer_runtime_filter(const
doris::TRuntimeFilterDesc& desc,
+ bool need_local_merge,
+ doris::IRuntimeFilter**
producer_filter,
+ bool build_bf_exactly) {
+ if (desc.has_remote_targets || need_local_merge) {
+
RETURN_IF_ERROR(global_runtime_filter_mgr()->register_local_merge_producer_filter(
+ desc, query_options(), producer_filter, build_bf_exactly));
+ } else {
+ RETURN_IF_ERROR(local_runtime_filter_mgr()->register_producer_filter(
+ desc, query_options(), producer_filter, build_bf_exactly));
+ }
+}
+
+Status RuntimeState::register_consumer_runtime_filter(const
doris::TRuntimeFilterDesc& desc,
Review Comment:
warning: method 'register_consumer_runtime_filter' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status RuntimeState::register_consumer_runtime_filter(const
doris::TRuntimeFilterDesc& desc,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
