github-actions[bot] commented on code in PR #31334:
URL: https://github.com/apache/doris/pull/31334#discussion_r1500426699


##########
be/src/runtime/memory/mem_tracker_limiter.cpp:
##########
@@ -395,6 +395,14 @@ int64_t MemTrackerLimiter::free_top_memory_query(int64_t 
min_free_mem,
             profile, GCType::PROCESS);
 }
 
+int64_t MemTrackerLimiter::tg_free_top_memory_query(

Review Comment:
   warning: method 'tg_free_top_memory_query' can be made static 
[readability-convert-member-functions-to-static]
   
   ```suggestion
   static int64_t MemTrackerLimiter::tg_free_top_memory_query(
   ```
   



##########
be/src/runtime/memory/mem_tracker_limiter.cpp:
##########
@@ -522,6 +530,15 @@
             profile, GCType::PROCESS);
 }
 
+int64_t MemTrackerLimiter::tg_free_top_overcommit_query(

Review Comment:
   warning: method 'tg_free_top_overcommit_query' can be made static 
[readability-convert-member-functions-to-static]
   
   ```suggestion
   static int64_t MemTrackerLimiter::tg_free_top_overcommit_query(
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to