xinyiZzz commented on code in PR #31334:
URL: https://github.com/apache/doris/pull/31334#discussion_r1500647576
##########
be/src/runtime/task_group/task_group.cpp:
##########
@@ -113,14 +114,85 @@ void
TaskGroup::remove_mem_tracker_limiter(std::shared_ptr<MemTrackerLimiter> me
_mem_tracker_limiter_pool[group_num].trackers.erase(mem_tracker_ptr);
}
-void TaskGroup::task_group_info(TaskGroupInfo* tg_info) const {
- std::shared_lock<std::shared_mutex> r_lock(_mutex);
- tg_info->id = _id;
- tg_info->name = _name;
- tg_info->cpu_share = _cpu_share;
- tg_info->memory_limit = _memory_limit;
- tg_info->enable_memory_overcommit = _enable_memory_overcommit;
- tg_info->version = _version;
+int64_t TaskGroup::gc_memory(int64_t need_free_mem, RuntimeProfile* profile) {
Review Comment:
In future, more expect to put it into a new class `xxxxGC`, together with
other GC methods of `MemTrackerLimiter`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
