gavinchou commented on code in PR #31628:
URL: https://github.com/apache/doris/pull/31628#discussion_r1512190108
##########
fe/fe-core/src/main/java/org/apache/doris/common/util/PropertyAnalyzer.java:
##########
@@ -984,6 +987,15 @@ public static String analyzeStoragePolicy(Map<String,
String> properties) {
return storagePolicy;
}
+ public static String analyzeStorageVault(Map<String, String> properties) {
Review Comment:
what's this for? it seems unused
##########
fe/fe-core/src/main/java/org/apache/doris/cloud/datasource/CloudInternalCatalog.java:
##########
@@ -145,11 +148,19 @@ protected Partition createPartitionWithIndices(long dbId,
OlapTable tbl, long pa
tbl.getEnableUniqueKeyMergeOnWrite(),
tbl.storeRowColumn(), indexMeta.getSchemaVersion());
requestBuilder.addTabletMetas(builder);
}
+ if (!storageVaultIdSet) {
+ requestBuilder.setStorageVaultName(storageVaultName);
+ }
LOG.info("create tablets, dbId: {}, tableId: {}, tableName: {},
partitionId: {}, partitionName: {}, "
+ "indexId: {}",
dbId, tbl.getId(), tbl.getName(), partitionId,
partitionName, indexId);
- sendCreateTabletsRpc(requestBuilder);
+ // dataProperty.setStorageVaultId(storageVaultId);
Review Comment:
we have to check the existence when creating a table with storage vault,
it seems that check is missing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
