ByteYue commented on code in PR #31628:
URL: https://github.com/apache/doris/pull/31628#discussion_r1512244177
##########
fe/fe-core/src/main/java/org/apache/doris/cloud/datasource/CloudInternalCatalog.java:
##########
@@ -145,11 +148,19 @@ protected Partition createPartitionWithIndices(long dbId,
OlapTable tbl, long pa
tbl.getEnableUniqueKeyMergeOnWrite(),
tbl.storeRowColumn(), indexMeta.getSchemaVersion());
requestBuilder.addTabletMetas(builder);
}
+ if (!storageVaultIdSet) {
+ requestBuilder.setStorageVaultName(storageVaultName);
+ }
LOG.info("create tablets, dbId: {}, tableId: {}, tableName: {},
partitionId: {}, partitionName: {}, "
+ "indexId: {}",
dbId, tbl.getId(), tbl.getName(), partitionId,
partitionName, indexId);
- sendCreateTabletsRpc(requestBuilder);
+ // dataProperty.setStorageVaultId(storageVaultId);
Review Comment:
Currently the existence check logic lies in MS's code, so the rpc procedure
already overlaps the check logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
