HappenLee commented on a change in pull request #6971:
URL: https://github.com/apache/incubator-doris/pull/6971#discussion_r744450364
##########
File path: be/src/olap/hll.h
##########
@@ -33,6 +33,7 @@ class Slice;
const static int HLL_COLUMN_PRECISION = 14;
const static int HLL_ZERO_COUNT_BITS = (64 - HLL_COLUMN_PRECISION);
const static int HLL_EXPLICIT_INT64_NUM = 160;
+const static int HLL_EXPLICIT_INT64_NUM_DOUBLE = HLL_EXPLICIT_INT64_NUM*2;
Review comment:
HLL_EXPLICIT_INT64_NUM * 2
##########
File path: be/src/olap/hll.h
##########
@@ -154,7 +174,7 @@ class HyperLogLog {
HllDataType _type = HLL_DATA_EMPTY;
uint32_t _explicit_data_num = 0;
- uint64_t _explicit_data[HLL_EXPLICIT_INT64_NUM * 2];
+ uint64_t* _explicit_data = nullptr;
Review comment:
directly use the raw ptr is dangerous and complex. Rethink shoule we
replace is use std::unique_ptr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
