zuochunwei commented on a change in pull request #6971:
URL: https://github.com/apache/incubator-doris/pull/6971#discussion_r745398893
##########
File path: be/src/olap/hll.h
##########
@@ -154,7 +174,7 @@ class HyperLogLog {
HllDataType _type = HLL_DATA_EMPTY;
uint32_t _explicit_data_num = 0;
- uint64_t _explicit_data[HLL_EXPLICIT_INT64_NUM * 2];
+ uint64_t* _explicit_data = nullptr;
Review comment:
no need replace with unique_ptr, keep style consistency with uint8_t
*_registers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
