This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git
commit 6888e52365efcca51e2b29067b7c4ef339dd4568 Author: Gabriel <[email protected]> AuthorDate: Thu Mar 21 14:38:49 2024 +0800 [pipelineX](fix) Fix illegal memory access (#32602) --- be/src/pipeline/pipeline_x/operator.cpp | 9 --------- be/src/pipeline/pipeline_x/operator.h | 2 -- be/src/vec/sink/writer/async_result_writer.h | 8 -------- 3 files changed, 19 deletions(-) diff --git a/be/src/pipeline/pipeline_x/operator.cpp b/be/src/pipeline/pipeline_x/operator.cpp index ff73bb92268..093bf17f46b 100644 --- a/be/src/pipeline/pipeline_x/operator.cpp +++ b/be/src/pipeline/pipeline_x/operator.cpp @@ -510,15 +510,6 @@ Status AsyncWriterSink<Writer, Parent>::sink(RuntimeState* state, vectorized::Bl return _writer->sink(block, eos); } -template <typename Writer, typename Parent> - requires(std::is_base_of_v<vectorized::AsyncResultWriter, Writer>) -std::string AsyncWriterSink<Writer, Parent>::debug_string(int indentation_level) const { - fmt::memory_buffer debug_string_buffer; - fmt::format_to(debug_string_buffer, "{}, writer : {}", Base::debug_string(indentation_level), - _writer->debug_string()); - return fmt::to_string(debug_string_buffer); -} - template <typename Writer, typename Parent> requires(std::is_base_of_v<vectorized::AsyncResultWriter, Writer>) Status AsyncWriterSink<Writer, Parent>::close(RuntimeState* state, Status exec_status) { diff --git a/be/src/pipeline/pipeline_x/operator.h b/be/src/pipeline/pipeline_x/operator.h index ba3e74cd975..06ba93a36f3 100644 --- a/be/src/pipeline/pipeline_x/operator.h +++ b/be/src/pipeline/pipeline_x/operator.h @@ -770,8 +770,6 @@ public: Status sink(RuntimeState* state, vectorized::Block* block, bool eos); - std::string debug_string(int indentation_level) const override; - std::vector<Dependency*> dependencies() const override { return {_async_writer_dependency.get()}; } diff --git a/be/src/vec/sink/writer/async_result_writer.h b/be/src/vec/sink/writer/async_result_writer.h index 974aa5ee61a..7f9700486da 100644 --- a/be/src/vec/sink/writer/async_result_writer.h +++ b/be/src/vec/sink/writer/async_result_writer.h @@ -83,14 +83,6 @@ public: return _writer_status; } - std::string debug_string() const { - fmt::memory_buffer debug_string_buffer; - fmt::format_to(debug_string_buffer, - "{}, _eos = {}, _writer_thread_closed = {}, _writer_status = {}", _eos, - _writer_thread_closed, _writer_status.to_string()); - return fmt::to_string(debug_string_buffer); - } - protected: Status _projection_block(Block& input_block, Block* output_block); const VExprContextSPtrs& _vec_output_expr_ctxs; --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
