This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git
commit 886aabda31d019e57f725ab1ee930b85e6fecfbb Author: wangbo <[email protected]> AuthorDate: Thu Mar 21 13:56:04 2024 +0800 [Fix](executor) Fix insert select not close coordinator #32571 --- .../nereids/trees/plans/commands/insert/AbstractInsertExecutor.java | 1 + fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java | 6 +++++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/insert/AbstractInsertExecutor.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/insert/AbstractInsertExecutor.java index 1a9ce2d744d..922dae6d40b 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/insert/AbstractInsertExecutor.java +++ b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/insert/AbstractInsertExecutor.java @@ -172,6 +172,7 @@ public abstract class AbstractInsertExecutor { onFail(t); return; } finally { + coordinator.close(); executor.updateProfile(true); QeProcessorImpl.INSTANCE.unregisterQuery(ctx.queryId()); } diff --git a/fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java b/fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java index 3d4e8cb75f5..9da938ee746 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java +++ b/fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java @@ -634,7 +634,11 @@ public class Coordinator implements CoordInterface { @Override public void close() { if (queryQueue != null && queueToken != null) { - queryQueue.returnToken(queueToken); + try { + queryQueue.returnToken(queueToken); + } catch (Throwable t) { + LOG.error("error happens when coordinator close ", t); + } } } --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
