github-actions[bot] commented on code in PR #33846:
URL: https://github.com/apache/doris/pull/33846#discussion_r1570471435
##########
be/src/runtime/routine_load/routine_load_task_executor.cpp:
##########
@@ -180,6 +180,31 @@ Status
RoutineLoadTaskExecutor::get_kafka_latest_offsets_for_partitions(
return st;
}
+Status RoutineLoadTaskExecutor::_get_kafka_latest_offsets_for_partitions(
Review Comment:
warning: method '_get_kafka_latest_offsets_for_partitions' can be made
static [readability-convert-member-functions-to-static]
be/src/runtime/routine_load/routine_load_task_executor.h:71:
```diff
- Status
_get_kafka_latest_offsets_for_partitions(std::shared_ptr<DataConsumerGroup>
consumer_grp,
+ static Status
_get_kafka_latest_offsets_for_partitions(std::shared_ptr<DataConsumerGroup>
consumer_grp,
```
##########
be/src/runtime/routine_load/routine_load_task_executor.cpp:
##########
@@ -371,6 +396,8 @@
// wait for all consumers finished
HANDLE_ERROR(ctx->future.get(), "consume failed");
+ HANDLE_ERROR(_get_kafka_latest_offsets_for_partitions(consumer_grp, ctx),
"get kafka latest offsets failed");
Review Comment:
warning: boolean expression can be simplified by DeMorgan's theorem
[readability-simplify-boolean-expr]
```cpp
HANDLE_ERROR(_get_kafka_latest_offsets_for_partitions(consumer_grp,
ctx), "get kafka latest offsets failed");
^
```
<details>
<summary>Additional context</summary>
**be/src/runtime/routine_load/routine_load_task_executor.cpp:321:** expanded
from macro 'HANDLE_ERROR'
```cpp
if (UNLIKELY(!_status_.ok() && !_status_.is<PUBLISH_TIMEOUT>())) { \
^
```
**be/src/common/compiler_util.h:35:** expanded from macro 'UNLIKELY'
```cpp
#define UNLIKELY(expr) __builtin_expect(!!(expr), 0)
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
