github-actions[bot] commented on code in PR #33846:
URL: https://github.com/apache/doris/pull/33846#discussion_r1572136416
##########
be/src/runtime/routine_load/data_consumer_group.cpp:
##########
@@ -194,11 +200,12 @@ Status
KafkaDataConsumerGroup::start_all(std::shared_ptr<StreamLoadContext> ctx,
return Status::OK();
}
-void KafkaDataConsumerGroup::actual_consume(std::shared_ptr<DataConsumer>
consumer,
- BlockingQueue<RdKafka::Message*>*
queue,
- int64_t max_running_time_ms,
ConsumeFinishCallback cb) {
+void KafkaDataConsumerGroup::actual_consume(
Review Comment:
warning: method 'actual_consume' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void KafkaDataConsumerGroup::actual_consume(
```
##########
be/src/runtime/routine_load/data_consumer.cpp:
##########
@@ -384,8 +388,8 @@
// get latest offsets for given partitions
Status KafkaDataConsumer::get_latest_offsets_for_partitions(
- const std::vector<int32_t>& partition_ids, std::vector<PIntegerPair>*
offsets,
- int timeout) {
+ const std::vector<int32_t>& partition_ids,
+ std::shared_ptr<std::vector<PIntegerPair>> offsets, int timeout) {
Review Comment:
warning: method 'get_latest_offsets_for_partitions' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status KafkaDataConsumer::get_latest_offsets_for_partitions(
```
##########
be/src/runtime/routine_load/data_consumer.cpp:
##########
@@ -187,8 +188,9 @@ Status KafkaDataConsumer::assign_topic_partitions(
return Status::OK();
}
-Status KafkaDataConsumer::group_consume(BlockingQueue<RdKafka::Message*>*
queue,
- int64_t max_running_time_ms) {
+Status KafkaDataConsumer::group_consume(
Review Comment:
warning: function 'group_consume' exceeds recommended size/complexity
thresholds [readability-function-size]
```cpp
Status KafkaDataConsumer::group_consume(
^
```
<details>
<summary>Additional context</summary>
**be/src/runtime/routine_load/data_consumer.cpp:190:** 93 lines including
whitespace and comments (threshold 80)
```cpp
Status KafkaDataConsumer::group_consume(
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
