HappenLee commented on a change in pull request #7751:
URL: https://github.com/apache/incubator-doris/pull/7751#discussion_r783903210
##########
File path: be/src/vec/core/block.cpp
##########
@@ -843,6 +843,17 @@ void MutableBlock::add_row(const Block* block, int row) {
}
}
+void MutableBlock::add_rows(const Block* block, const int* row_begin, const
int* row_end) {
+ auto& src_columns_with_schema = block->get_columns_with_type_and_name();
+ for (size_t i = 0; i < _columns.size(); ++i) {
+ auto& dst = _columns[i];
+ auto& src = *src_columns_with_schema[i].column.get();
+ for (const int* row = row_begin; row != row_end; ++row) {
+ dst->insert_from(src, *row);
Review comment:
here will be virtual function call. so we should implement a function in
column.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
