zuochunwei commented on a change in pull request #7751:
URL: https://github.com/apache/incubator-doris/pull/7751#discussion_r785673245
##########
File path: be/src/vec/sink/vdata_stream_sender.h
##########
@@ -261,5 +274,24 @@ class VDataStreamSender::Channel {
size_t _capacity;
bool _is_local;
};
+
+template <typename Channels, typename HashVals>
+Status VDataStreamSender::channel_add_rows(Channels& channels, int
num_channels, const HashVals& hash_vals, int rows, Block* block) {
+ std::vector<int> channel2rows[num_channels];
Review comment:
channel2rows is used for aggregate rows for channels, it's a temporary
data served for the function of channel_add_rows, it's not used in other member
functions, it's not has getter/setter, it's not visiable to outer, so i don't
think make it as member data is a good idea.
for performance, if you can prove it with rewriting code, please tell me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
