dataroaring commented on code in PR #34888:
URL: https://github.com/apache/doris/pull/34888#discussion_r1602950888
##########
fe/fe-core/src/main/java/org/apache/doris/binlog/TableBinlog.java:
##########
@@ -305,10 +338,16 @@ public void getBinlogInfo(Database db, BaseProcResult
result) {
info.add(lastBinlogCommittedTime);
info.add(readableLastBinlogCommittedTime);
String binlogTtlSeconds = null;
+ String binlogMaxBytes = null;
+ String binlogMaxHistoryNums = null;
if (binlogConfig != null) {
binlogTtlSeconds =
String.valueOf(binlogConfig.getTtlSeconds());
+ binlogMaxBytes = String.valueOf(binlogConfig.getMaxBytes());
Review Comment:
Should we set a default max bytes as 5% of xmx?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
