w41ter commented on code in PR #34888:
URL: https://github.com/apache/doris/pull/34888#discussion_r1604305965
##########
fe/fe-core/src/main/java/org/apache/doris/binlog/TableBinlog.java:
##########
@@ -305,10 +338,16 @@ public void getBinlogInfo(Database db, BaseProcResult
result) {
info.add(lastBinlogCommittedTime);
info.add(readableLastBinlogCommittedTime);
String binlogTtlSeconds = null;
+ String binlogMaxBytes = null;
+ String binlogMaxHistoryNums = null;
if (binlogConfig != null) {
binlogTtlSeconds =
String.valueOf(binlogConfig.getTtlSeconds());
+ binlogMaxBytes = String.valueOf(binlogConfig.getMaxBytes());
Review Comment:
Based on the known information, it seems that using a time-based gc is
already effectively controlling memory usage. Directly limiting memory usage to
a maximum of only 5% would introduce other variables and compromise stability.
It is recommended to maintain consistency with previous behavior for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
