yiguolei commented on code in PR #35493:
URL: https://github.com/apache/doris/pull/35493#discussion_r1616589118
##########
be/src/olap/rowset/segment_v2/binary_dict_page.cpp:
##########
@@ -45,17 +46,27 @@ BinaryDictPageBuilder::BinaryDictPageBuilder(const
PageBuilderOptions& options)
_finished(false),
_data_page_builder(nullptr),
_dict_builder(nullptr),
- _encoding_type(DICT_ENCODING) {
+ _encoding_type(DICT_ENCODING) {}
+
+Status BinaryDictPageBuilder::init() {
+ RETURN_IF_ERROR_OR_CATCH_EXCEPTION(_init());
Review Comment:
add a flag to indicate init is called
and add dcheck to all method to check other method is called after init.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
