yiguolei commented on code in PR #35493:
URL: https://github.com/apache/doris/pull/35493#discussion_r1616971794
##########
be/src/olap/rowset/segment_v2/page_builder.h:
##########
@@ -91,5 +94,15 @@ class PageBuilder {
DISALLOW_COPY_AND_ASSIGN(PageBuilder);
};
+template <typename Derived>
+class PageBuilderHelper : public PageBuilder {
+public:
+ template <typename... Args>
+ static Status create(PageBuilder** builder, Args&&... args) {
+ *builder = new Derived(std::forward<Args>(args)...);
Review Comment:
use a unique ptr
if init failed, then it is auto released.
if status is error, user may not release the builder manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
