github-actions[bot] commented on code in PR #35632:
URL: https://github.com/apache/doris/pull/35632#discussion_r1619777786
##########
be/src/service/backend_service.cpp:
##########
@@ -750,10 +751,40 @@ void BaseBackendService::open_scanner(TScanOpenResult&
result_, const TScanOpenP
} else {
p_context->keep_alive_min = 5;
}
+
+ Status exec_st;
+ TQueryPlanInfo t_query_plan_info;
+ {
+ const std::string& opaqued_query_plan = params.opaqued_query_plan;
+ std::string query_plan_info;
+ // base64 decode query plan
+ if (!base64_decode(opaqued_query_plan, &query_plan_info)) {
+ LOG(WARNING) << "open context error: base64_decode decode
opaqued_query_plan failure";
+ std::stringstream msg;
+ msg << "query_plan_info: " << query_plan_info
+ << " validate error, should not be modified after returned
Doris FE processed";
+ exec_st = Status::InvalidArgument(msg.str());
+ }
+
+ const uint8_t* buf = (const uint8_t*)query_plan_info.data();
Review Comment:
warning: use auto when initializing with a cast to avoid duplicating the
type name [modernize-use-auto]
```suggestion
const auto* buf = (const uint8_t*)query_plan_info.data();
```
##########
be/src/runtime/fragment_mgr.h:
##########
@@ -18,6 +18,7 @@
#pragma once
#include <gen_cpp/FrontendService_types.h>
Review Comment:
warning: 'gen_cpp/FrontendService_types.h' file not found
[clang-diagnostic-error]
```cpp
#include <gen_cpp/FrontendService_types.h>
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
