yiguolei commented on code in PR #35632:
URL: https://github.com/apache/doris/pull/35632#discussion_r1620399092
##########
be/src/runtime/fragment_mgr.cpp:
##########
@@ -997,25 +997,16 @@ void FragmentMgr::cancel_instance(const TUniqueId
instance_id, const Status reas
std::shared_ptr<PlanFragmentExecutor> non_pipeline_ctx;
{
std::lock_guard<std::mutex> state_lock(_lock);
- const bool is_pipeline_instance = _pipeline_map.contains(instance_id);
- if (is_pipeline_instance) {
- auto itr = _pipeline_map.find(instance_id);
- if (itr != _pipeline_map.end()) {
- pipeline_ctx = itr->second;
- } else {
- LOG(WARNING) << "Could not find the pipeline instance id:" <<
print_id(instance_id)
- << " to cancel";
- return;
- }
+ CHECK(!_pipeline_map.contains(instance_id))
Review Comment:
DO NOT use check to avoid core online.
Using DCHECK and print warning message please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
