caiconghui commented on a change in pull request #8035:
URL: https://github.com/apache/incubator-doris/pull/8035#discussion_r806904837
##########
File path:
fe/fe-core/src/main/java/org/apache/doris/http/rest/BootstrapFinishAction.java
##########
@@ -37,6 +37,7 @@
* {"status":"OK","msg":"Success","replayedJournal"=123456, "queryPort"=9000,
"rpcPort"=9001}
* {"status":"FAILED","msg":"err info..."}
*/
+@Deprecated
Review comment:
> Why deprecate this?
get heartbeat info by rpc method is a more stable way, once get heartbeat by
thrift, BootstrapFinishAction is not needed anymore, here we just keep
compatible when fe upgrade
##########
File path:
fe/fe-core/src/main/java/org/apache/doris/http/rest/BootstrapFinishAction.java
##########
@@ -37,6 +37,7 @@
* {"status":"OK","msg":"Success","replayedJournal"=123456, "queryPort"=9000,
"rpcPort"=9001}
* {"status":"FAILED","msg":"err info..."}
*/
+@Deprecated
Review comment:
> I thought that `BootstrapFinishAction` is nothing to do with the
heartbeat? It is used for checking whether the FE is started successfully.
controller.registerHandler(HttpMethod.GET, "/api/bootstrap", new
BootstrapFinishAction(controller))
it is now used for heartbeat
private HeartbeatResponse getHeartbeatResponseByHttp() {
String url = "http://"; + fe.getHost() + ":" + Config.http_port
+ "/api/bootstrap?cluster_id=" + clusterId + "&token=" +
token;
##########
File path:
fe/fe-core/src/main/java/org/apache/doris/http/rest/BootstrapFinishAction.java
##########
@@ -37,6 +37,7 @@
* {"status":"OK","msg":"Success","replayedJournal"=123456, "queryPort"=9000,
"rpcPort"=9001}
* {"status":"FAILED","msg":"err info..."}
*/
+@Deprecated
Review comment:
1. we still can use thrift to check whether FE is started, which is
duplicated with http method
2. no need, user just upgrade it, no need to know the change, because when
user use the new fe version, the cluster will use thrift to get fe heartbeat
info by default and cannot change , we still keep BootstrapFinishAction for
compatibility
3. done
##########
File path:
fe/fe-core/src/main/java/org/apache/doris/http/rest/BootstrapFinishAction.java
##########
@@ -37,6 +37,7 @@
* {"status":"OK","msg":"Success","replayedJournal"=123456, "queryPort"=9000,
"rpcPort"=9001}
* {"status":"FAILED","msg":"err info..."}
*/
+@Deprecated
Review comment:
1. no need, user just upgrade it, no need to know the change, because
when user use the new fe version, the cluster will use thrift to get fe
heartbeat info by default and cannot change , now we still keep
BootstrapFinishAction and need to remove deprecate
2. done for completing the required fields in PR template.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
